Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Select combobox improvements #200

Open
mikeburgh opened this issue Oct 15, 2024 · 4 comments
Open

Single Select combobox improvements #200

mikeburgh opened this issue Oct 15, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@mikeburgh
Copy link
Contributor

For the combo box option, is it possible to enforce the entered value must match a provided value when using the native form validation.

Also, is it possible to get the ability to render an icon at the start of each value.

@bendera
Copy link
Member

bendera commented Oct 16, 2024

For the combo box option, is it possible to enforce the entered value must match a provided value when using the native form validation.

Currently, in combobox mode, it allows committing an invalid value that is not present in the list. In this case, the value will be an empty string, and the selectedIndex will be -1. This is definitely a bug. For validation, you can use the required attribute, which is the only applicable validation option for a select element. (I've just realized the validation is also buggy.)

Also, is it possible to get the ability to render an icon at the start of each value.

With the current implementation, it's only feasible with codicons. Would that be acceptable for you?

@mikeburgh
Copy link
Contributor Author

Thanks, codicons will work.. I think I should be able to switch those for other icons easily enough post render if the need arises.

@bendera bendera added the enhancement New feature or request label Oct 18, 2024
@bendera
Copy link
Member

bendera commented Oct 22, 2024

I've realized with the current implementation the performance is drastically degrading if icons are rendered in the options. It will be complex task. I can't estimate when it will be finished.

@mikeburgh
Copy link
Contributor Author

No worries, I am getting around to seeing if I can patch it in after the render.. if I can I will close this as that will take care of my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants