Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coffeescript v2 support? #264

Open
benlavalley opened this issue Dec 10, 2017 · 4 comments · May be fixed by #268
Open

Coffeescript v2 support? #264

benlavalley opened this issue Dec 10, 2017 · 4 comments · May be fixed by #268

Comments

@benlavalley
Copy link

There are some breaking changes between Coffeescript v1 and v2 - I tried to figure them out to get job-collection compatible with v2, but I know little to nothing about Coffeescript and don't use many of Javascript's advanced capabilities yet, so I couldn't figure out making all the necessary changes.

Figured I'd pose the question about having job-collection updated to support v2 before it goes into it's maintenance mode come January.

@vsivsi
Copy link
Owner

vsivsi commented Dec 12, 2017

Thanks for the heads-up on this. I'm not writing a lot of CS these days, but I'll look into this and see if the required changes are straightforward or not. Based on the claims in the CS 2.0 announcement, it shouldn't be too crazy.

@mitar
Copy link
Collaborator

mitar commented Jan 16, 2018

I just had to update all my packages to CoffeeScript 2. Meteor does not allow both CoffeeScript 1 and CoffeeScript 2 to coexist at the same time in the same app.

I could try to do a PR, but I see that this package is in maintenance only mode.

@vsivsi
Copy link
Owner

vsivsi commented Jan 16, 2018

NP. I’ll accept a PR for that.

@mitar mitar linked a pull request Jan 17, 2018 that will close this issue
@mitar
Copy link
Collaborator

mitar commented Jan 17, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants