Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded breakpoint in AppRouter #295

Open
bgoyarts opened this issue Mar 27, 2023 · 0 comments
Open

Hardcoded breakpoint in AppRouter #295

bgoyarts opened this issue Mar 27, 2023 · 0 comments

Comments

@bgoyarts
Copy link

bgoyarts commented Mar 27, 2023

Describe the bug
It is possible inside a custom theme styles/configs/style.json to specify breakpoints for your theme. However, inside my-account a hardcoded breakpoint is used

<Media query="(max-width: 45em)">
. This conflicts with the generated tachyons file from the supplied config. Result of this is that certain elements disappear in a empty space between breakpoints. An example would be the back button inside the pageHeader.

To Reproduce

  1. Use the following breakpoints for your app styles/config/style.json
    {
      "s": 20
    },
    {
      "ns": {
        "value": 40,
        "minWidth": true
      }
    },
    {
      "m": {
        "value": 40,
        "minWidth": true
      }
    },
    {
      "l": {
        "value": 64,
        "minWidth": true
      }
    },
    {
      "xl": {
        "value": 80,
        "minWidth": true
      }
    }
  ],
  1. Set your screen to a width of 650px
  2. Open the profile page
  3. See that the back button is not rendered

Expected behavior
Back button should be visible

Screenshots
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant