Skip to content

Commit

Permalink
fix(menu): use the primary, secondary, and tertiary props (#2009)
Browse files Browse the repository at this point in the history
  • Loading branch information
matheusps authored Oct 16, 2024
2 parents 297a869 + daee9be commit e2a28c7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions packages/shoreline/src/components/menu/menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const Menu = forwardRef<HTMLDivElement, MenuProps>(
children,
label,
asChild = false,
variant = 'secondary',
variant = 'tertiary',
type = 'menu',
iconOnly = false,
size = 'normal',
Expand Down Expand Up @@ -80,7 +80,7 @@ function getIcon(type: MenuProps['type'] = 'menu') {
}
}

type InheritedOptions = Pick<ButtonProps, 'variant' | 'size' | 'disabled'> &
type InheritedOptions = Pick<ButtonProps, 'size' | 'disabled'> &
Pick<
MenuProviderOptions,
'open' | 'setOpen' | 'defaultOpen' | 'store' | 'placement'
Expand All @@ -106,6 +106,11 @@ export interface MenuOptions extends InheritedOptions {
* @default false
*/
iconOnly?: boolean
/**
* Change between color combinations.
* @default 'tertiary'
*/
variant?: 'primary' | 'secondary' | 'tertiary'
}

export type MenuProps = MenuOptions & ComponentPropsWithoutRef<'div'>

0 comments on commit e2a28c7

Please sign in to comment.