no-cache smart queries are throwing exceptions in optimistic UI updates (#280)

gaberudy · Akryum · commit 82d6c02f7b02 · 2018-05-21T19:37:57.000+02:00
This short circuits unproductive cache work for no-cache queries that will not exist
diff --git a/src/smart-query.js b/src/smart-query.js
@@ -87,10 +87,12 @@ export default class SmartQuery extends SmartApollo {
       })
     }
 
-    const currentResult = this.maySetLoading()
+    if (this.options.fetchPolicy !== "no-cache") {
+      const currentResult = this.maySetLoading()
 
-    if (!currentResult.loading) {
-      this.nextResult(currentResult)
+      if (!currentResult.loading) {
+        this.nextResult(currentResult)
+      }
     }
 
     super.executeApollo(variables)

Original file line number	Diff line number	Diff line change
`@@ -87,10 +87,12 @@ export default class SmartQuery extends SmartApollo {`
`87`	`87`	`})`
`88`	`88`	`}`
`89`	`89`
`90`		`- const currentResult = this.maySetLoading()`
	`90`	`+ if (this.options.fetchPolicy !== "no-cache") {`
	`91`	`+ const currentResult = this.maySetLoading()`
`91`	`92`
`92`		`- if (!currentResult.loading) {`
`93`		`- this.nextResult(currentResult)`
	`93`	`+ if (!currentResult.loading) {`
	`94`	`+ this.nextResult(currentResult)`
	`95`	`+ }`
`94`	`96`	`}`
`95`	`97`
`96`	`98`	`super.executeApollo(variables)`