-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sfc-playground): remove comment nodes in the production env #9594
base: main
Are you sure you want to change the base?
fix(sfc-playground): remove comment nodes in the production env #9594
Conversation
6cf7f2f
to
42a7069
Compare
Size ReportBundles
Usages
|
42a7069
to
3b6d1c6
Compare
I'm not sure about this. By default, production builds do remove comments, but it's configurable. It isn't safe to assume that comments are always stripped from production builds. While I can see the argument for making the Playground consistent with the default build configuration, I think it makes it much less useful for bug reproductions. The compiler code for handling Even if this PR is merged, I don't think it is a fix for the original issue, it just hides it in the Playground. The original problem still exists in a Vite-based project with |
fixed #9591
In a production env, comments should be removed.