fix(language-core): correct logic for defineSlots destructuring (#4326)

Co-authored-by: Johnson Chu <[email protected]>
vuejs · Apr 30, 2024 · d523035 · d523035
1 parent fd25386
commit d523035
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/language-core/lib/codegen/script/scriptSetup.ts b/packages/language-core/lib/codegen/script/scriptSetup.ts
@@ -163,15 +163,14 @@ function* generateSetupFunction(
 		}
 	}
 	if (scriptSetupRanges.slots.define) {
-		if (!scriptSetupRanges.slots.name) {
-			setupCodeModifies.push([[`const __VLS_slots = `], scriptSetupRanges.slots.define.start, scriptSetupRanges.slots.define.start]);
-		}
-		else if (scriptSetupRanges.slots.isObjectBindingPattern) {
+		if (scriptSetupRanges.slots.isObjectBindingPattern) {
 			setupCodeModifies.push([
 				[`__VLS_slots;\nconst __VLS_slots = `],
 				scriptSetupRanges.slots.define.start,
 				scriptSetupRanges.slots.define.start,
 			]);
+		} else if (!scriptSetupRanges.slots.name) {
+			setupCodeModifies.push([[`const __VLS_slots = `], scriptSetupRanges.slots.define.start, scriptSetupRanges.slots.define.start]);
 		}
 	}
 	if (scriptSetupRanges.emits.define && !scriptSetupRanges.emits.name) {

diff --git a/test-workspace/tsc/vue3/#4326/main.vue b/test-workspace/tsc/vue3/#4326/main.vue
@@ -0,0 +1,11 @@
+<script setup lang="ts">
+import { exactType } from 'tsc/shared';
+
+const { bottom } = defineSlots<{
+	bottom: (props: { num: number; }) => any[],
+}>();
+
+exactType(bottom, {} as (props: {
+	num: number;
+}) => any[]);
+</script>