[Bug]: associateGuestCart failure prevents login popup success

[mrbrdo]

Expected Behavior

When associateGuestCart fails, the user should still be logged in and the associateGuestCart failure should be ignored.

Actual Behavior

The login popup displays the error (422 in my case) and does not close the login window. However, the user actually gets logged in, if you close the window.

The reason why I am getting the 422 error is another issue, but I don't know why I got it either.

Possible Solution

Failure of associate api call should not prevent login window treating login call as successful.

Steps to reproduce

Make associate api method return status 422, then try to login in the vue app.

What version of Spree integration are you using?

latest

What version of Node.js are you using?

14.18.1

What browser (and version) are you using?

Chrome

What operating system (and version) are you using?

Mac

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[rafalcymerys]

Hi @mrbrdo were you able to determine why you're getting this error?

I'm not sure if ignoring it is safe - AFAIR we can end up in a state where the browser has a cart loaded (the guest cart), but the next call to the fetchCart API will return a clean signed-in cart for the same user. This will cause more issues that will be more difficult to debug.

[mrbrdo]

No I did not. Based on my evaluation of the vue storefront over the last months I have determined it is not mature enough for my liking (the next.js one is even worse, don't get me wrong). I have switched to the legacy Rails frontend and it is a lot more stable for me.
I will leave the issue open but I will not get involved further for now.