Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Prevent to call AdobeCommerce when the data is not valid #1388

Open
1 task done
marc-arnoult opened this issue Nov 7, 2022 · 0 comments
Open
1 task done
Labels
bug Something isn't working triage-needed Issues that need to be checked

Comments

@marc-arnoult
Copy link
Contributor

Expected Behavior

Actually when a client and/or a bot make a call to VSF all the data is submitted to AdobeCommerce, we should Fail fast and prevent to call AdobeCommerce when the data is not valid or even not present.

Actual Behavior

Every call is directly submitted to AdobeCommerce without validation.

It can lead to slowness of NodeJS and AdobeCommerce. Specially when a bot attack and/or crawl our endpoints.

Possible Solution

Validate the data before submitted them to AdobeCommerce.

Steps to reproduce

Make a fetch call with an empty and/or invalid body.

What version of Magento 2 integration are you using?

2.4.5

What version of Node.js are you using?

16.13

What browser (and version) are you using?

Chrome, Safari

What operating system (and version) are you using?

macOS

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@marc-arnoult marc-arnoult added bug Something isn't working triage-needed Issues that need to be checked labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage-needed Issues that need to be checked
Projects
None yet
Development

No branches or pull requests

1 participant