You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
diff --git a/packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.js b/packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.js
index 4b15e8611..d946fcfd1 100644
--- a/packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.js+++ b/packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.js@@ -10,78 +10,10 @@ export default {
title: "Components/Molecules/BottomModal",
component: SfBottomModal,
parameters: {
- // do not modify cssprops manually, they are generated automatically by update-components-docs script- cssprops: {- "bottom-modal-position": { value: "fixed", control: "text" },- "bottom-modal-width": { value: "100%", control: "text" },- "bottom-modal-top": { value: "", control: "text" },- "bottom-modal-bottom": { value: "0", control: "text" },- "bottom-modal-right": { value: "0", control: "text" },- "bottom-modal-transform": { value: "", control: "text" },- "bottom-modal-container-padding": { value: "", control: "text" },- "bottom-modal-background": { value: "var(--c-white)", control: "text" },- "bottom-modal-container-font": { value: "", control: "text" },- "bottom-modal-container-font-weight": {- value: "var(--font-weight--light)",- control: "text",- },- "bottom-modal-container-font-size": {- value: "var(--font-size--base)",- control: "text",- },- "bottom-modal-container-font-line-height": {- value: "1.6",- control: "text",- },- "bottom-modal-container-font-family": {- value: "var(--font-family--primary)",- control: "text",- },- "bottom-modal-height": { value: "", control: "text" },- "bottom-modal-title-padding": {- value: "var(--spacer-sm) var(--spacer-lg)",- control: "text",- },- "bottom-modal-title-color": { value: "var(--c-text)", control: "text" },- "bottom-modal-title-text-align": { value: "center", control: "text" },- "characteristic-description-font": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "list-item-margin": {- value: "0 var(--spacer-sm)",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-text-transform": {- value: "capitalize",- description: "Overridden other component's CSS variable",- control: "text",- },- "heading-title-font": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-display": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-background": {- value: "var(--_c-light-primary)",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-color": {- value: "var(--c-text-muted)",- description: "Overridden other component's CSS variable",- control: "text",- },- },- // end of code generated automatically- docs: {+ // do not modify cssprops manually, they are generated automatically by update-components-docs script
+ cssprops: {"bottom-modal-position":{"value":"fixed","control":"text"},"bottom-modal-width":{"value":"100%","control":"text"},"bottom-modal-top":{"value":"","control":"text"},"bottom-modal-bottom":{"value":"0","control":"text"},"bottom-modal-right":{"value":"0","control":"text"},"bottom-modal-transform":{"value":"","control":"text"},"bottom-modal-container-padding":{"value":"","control":"text"},"bottom-modal-background":{"value":"var(--c-white)","control":"text"},"bottom-modal-container-font":{"value":"","control":"text"},"bottom-modal-container-font-weight":{"value":"var(--font-weight--light)","control":"text"},"bottom-modal-container-font-size":{"value":"var(--font-size--base)","control":"text"},"bottom-modal-container-font-line-height":{"value":"1.6","control":"text"},"bottom-modal-container-font-family":{"value":"var(--font-family--primary)","control":"text"},"bottom-modal-height":{"value":"","control":"text"},"bottom-modal-title-padding":{"value":"var(--spacer-sm) var(--spacer-lg)","control":"text"},"bottom-modal-title-color":{"value":"var(--c-text)","control":"text"},"bottom-modal-title-text-align":{"value":"center","control":"text"},"characteristic-description-font":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"font-size--base":{"description":"Overridden other component's CSS variable","control":"text"},"font-weight--semibold":{"description":"Overridden other component's CSS variable","control":"text"},"list-item-margin":{"value":"0 var(--spacer-sm)","description":"Overridden other component's CSS variable","control":"text"},"button-text-transform":{"value":"capitalize","description":"Overridden other component's CSS variable","control":"text"},"font-size--sm":{"description":"Overridden other component's CSS variable","control":"text"},"heading-title-font":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"font-weight--normal":{"description":"Overridden other component's CSS variable","control":"text"},"font-size--xs":{"description":"Overridden other component's CSS variable","control":"text"},"font-weight--bold":{"description":"Overridden other component's CSS variable","control":"text"},"button-display":{"value":"none","description":"Overridden other component's CSS variable","control":"text"},"button-background":{"value":"var(--_c-light-primary)","description":"Overridden other component's CSS variable","control":"text"},"button-color":{"value":"var(--c-text-muted)","description":"Overridden other component's CSS variable","control":"text"}},
+ // end of code generated automatically+ docs: {
inlineStories: false,
iframeHeight: "300px",
description: {
The cssprops has been collapsed to a single line for all of the components. From here I am guessing what to try next...
What I think to try, is to add all these modified files to the git index and run yarn run lerna run precommit:
~/src/storefront-ui develop*
❯ git add --all~/src/storefront-ui develop*
❯ yarn run lerna run precommityarn run v1.22.17
$ ~storefront-ui/node_modules/.bin/lerna run precommitlerna notice cli v3.22.1lerna info versioning independentlerna info Executing command in 2 packages: "yarn run precommit"lerna info run Ran npm script 'precommit' in '@storefront-ui/shared' in 0.9s:
$ lint-stagedℹ No staged files match any configured task.lerna info run Ran npm script 'precommit' in '@storefront-ui/vue' in 10.7s:
$ lint-staged[STARTED] Preparing...[SUCCESS] Preparing...[STARTED] Running tasks...[STARTED] Running tasks for *.{js,vue}[STARTED] vue-cli-service lint --fix[SUCCESS] vue-cli-service lint --fix[SUCCESS] Running tasks for *.{js,vue}[SUCCESS] Running tasks...[STARTED] Applying modifications...[SUCCESS] Applying modifications...[STARTED] Cleaning up...[SUCCESS] Cleaning up...lerna success run Ran npm script 'precommit' in 2 packages in 11.6s:lerna success - @storefront-ui/sharedlerna success - @storefront-ui/vue✨ Done in 12.83s.
So, it is no longer collapsed on to one line but there are still updates to all of the modified component files.
This raises the question... Should all component files be getting modified like this when running update-components-docs?
Should these changes be commit to develop so the update-components-docs script doesn't cause the whole project to have modified files when it is run while developing?
One other note that I noticed... After yarn run update-components-docs and yarn run lerna run precommit, the file packages/vue/src/components/atoms/SfArrow/SfArrow.stories.js is still all collapsed to one line:
diff --git a/packages/vue/src/components/atoms/SfArrow/SfArrow.stories.js b/packages/vue/src/components/atoms/SfArrow/SfArrow.stories.js
index dcc9c7c21..c57cdeeb7 100644
--- a/packages/vue/src/components/atoms/SfArrow/SfArrow.stories.js+++ b/packages/vue/src/components/atoms/SfArrow/SfArrow.stories.js@@ -4,63 +4,10 @@ export default {
title: "Components/Atoms/Arrow",
component: SfArrow,
parameters: {
- // do not modify cssprops manually, they are generated automatically by update-components-docs script- cssprops: {- "arrow-justify-content": { value: "", control: "text" },- "arrow-icon-transform": { value: "", control: "text" },- "button-width": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-height": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-padding": {- value: "0 0.625rem",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-background": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-transition": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "icon-color": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-box-shadow": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- "box-shadow-transition-opacity-duration": {- value: "150ms",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-box-shadow-opacity": {- value: "0.25",- description: "Overridden other component's CSS variable",- control: "text",- },- "button-border-radius": {- value: "",- description: "Overridden other component's CSS variable",- control: "text",- },- },- // end of code generated automatically- docs: {+ // do not modify cssprops manually, they are generated automatically by update-components-docs script
+ cssprops: {"arrow-justify-content":{"value":"","control":"text"},"arrow-icon-transform":{"value":"","control":"text"},"button-width":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"button-height":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"button-padding":{"value":"0 0.625rem","description":"Overridden other component's CSS variable","control":"text"},"button-background":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"button-transition":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"icon-color":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"button-box-shadow":{"value":"","description":"Overridden other component's CSS variable","control":"text"},"box-shadow-transition-opacity-duration":{"value":"150ms","description":"Overridden other component's CSS variable","control":"text"},"button-box-shadow-opacity":{"value":"0.25","description":"Overridden other component's CSS variable","control":"text"},"button-border-radius":{"value":"","description":"Overridden other component's CSS variable","control":"text"}},
+ // end of code generated automatically+ docs: {
description: {
component: `Arrow component for sliders and navigation. It's Vue 2 functional component. To see css vars used in component please switch to canvas and CSS Custom Properties tab.`,
},
After a fresh clone, on the develop branch, running
yarn run update-components-docsmodifies all the component files...Checking the diff for one of the components,
packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.js:The
csspropshas been collapsed to a single line for all of the components. From here I am guessing what to try next...What I think to try, is to add all these modified files to the git index and run
yarn run lerna run precommit:The status of git is still all modified files:
The cached index diff of
packages/vue/src/components/molecules/SfBottomModal/SfBottomModal.stories.jsis now:So, it is no longer collapsed on to one line but there are still updates to all of the modified component files.
This raises the question... Should all component files be getting modified like this when running
update-components-docs?Should these changes be commit to develop so the
update-components-docsscript doesn't cause the whole project to have modified files when it is run while developing?One other note that I noticed... After
yarn run update-components-docsandyarn run lerna run precommit, the filepackages/vue/src/components/atoms/SfArrow/SfArrow.stories.jsis still all collapsed to one line:That doesn't seem right.
┆Issue is synchronized with this Jira Zadanie by Unito
The text was updated successfully, but these errors were encountered: