Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.5.7] Transition hide on leave is not applied with d-flex #13973

Closed
Glandos opened this issue Jul 23, 2021 · 3 comments
Closed
Assignees
Labels
C: Transitions T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Glandos
Copy link
Contributor

Glandos commented Jul 23, 2021

Environment

Vuetify Version: 2.5.7
Vue Version: 2.6.14
Browsers: Firefox 88.0
OS: Linux x86_64

Steps to reproduce

Wrap an element with d-flex with a transition that has hide-on-leave
Perform the transition

Expected Behavior

Leaving element is hidden

Actual Behavior

Leaving element is still displayed

Reproduction Link

https://codepen.io/glandos/pen/xxdPOOp

Other comments

See that display:none; on element applied by the transition is overriden by display: flex !important applied by the d-flex class.

@ghost ghost added the S: triage label Jul 23, 2021
@glen-84 glen-84 added the sass label Jul 29, 2021
@MrLewBrew
Copy link

I have the same issue with v-slide-x-transition and v-slide-x-reverse-transition, both using hide-on-leave and nested inside a v-card.

@KaelWD KaelWD added C: Transitions T: bug Functionality that does not work as intended/expected and removed S: triage sass labels Oct 7, 2021
@KaelWD KaelWD self-assigned this Oct 7, 2021
@KaelWD KaelWD added this to the v2.5.x milestone Oct 7, 2021
@KaelWD KaelWD closed this as completed in 0e5438b Oct 7, 2021
@everttrollip
Copy link

everttrollip commented Oct 22, 2021

@KaelWD after recently updating Vuetify to v2.5.x, I had some strange behaviour when using the v-show directive on an element wrapped with one of the vuetify transition components. For example, consider this,

<v-slide-y-transition hide-on-leave>
  <ct-loading small v-show="loading"></ct-loading>
</v-slide-y-transition>

in versions pre 2.5.x, this custom element ct-loading would only appear if loading is true. In v2.5.x I had to wrap ct-loading with a single top-level element in order for the directive to work properly (Thanks to the hint here)

<v-slide-y-transition hide-on-leave>
  <div>
    <ct-loading small v-show="loading"></ct-loading>
  </div>
</v-slide-y-transition>

I discovered in the release notes of v2.5.10 that for transitions the hideOnLeave display property was made !important (0e5438b). Since this commit ensures display:none; on element applied by the transition is overriden by display: flex !important, the v-show directive as shown in my example above no longer works as expected.

I wasn't sure if this was intentional? Or do I need to create a bug ticket for this issue?

@KaelWD
Copy link
Member

KaelWD commented Oct 22, 2021

Yes please open an issue with reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Transitions T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

5 participants