-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TDex flow (discovery & tdex registry) #11
Conversation
Let's have @bordalix to review as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
My only issue is not showing the user the true reason for the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also prefer to have all the constants on the same file.
This PR improves the tdex flow in the app:
tdexstore.ts
).coinstore.ts
).Trade.svelte
).marina.getCoins
call.it reuses the functions of tdex-app (see
utils/tdex.ts
file)Note that this PR does not add support for testnet or regtest (does it make sense on dex.vulpem.com?). And do not add any new "visual elements" like the number of providers/markets available etc... (may be useful ??).
it closes #4
@tiero @bordalix please review