Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Allow multiple filters per request #220

Open
ribtoks opened this issue May 8, 2022 · 3 comments
Open

[Enhancement] - Allow multiple filters per request #220

ribtoks opened this issue May 8, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ribtoks
Copy link

ribtoks commented May 8, 2022

Describe the bug
I cannot receive a list of instances filtered with tag and region using ListInstances API, because I'm receiving an error "Only one filter per request is allowed.". This error is frustrating to me because:

  • to achieve what I want, now I would need to create artificial tags that will consist of my old tags + concatenated region field (which is a "workaround engineering" that will require additional maintenance effort)
  • I do not understand such restriction necessity

To Reproduce
Steps to reproduce the behavior:
Construct govultr.ListOptions specifying Tag and Region in a single object.

Expected behavior
A ListInstances API call succeeds and returns instances in the specified region with the specified tag.

Screenshots

Desktop (please complete the following information where applicable:

  • OS: -
  • Language Version Go 1.17
  • Browser -
  • Version -

Additional context

@ribtoks ribtoks added the bug Something isn't working label May 8, 2022
@ddymko ddymko added enhancement New feature or request and removed bug Something isn't working labels May 8, 2022
@ddymko ddymko changed the title [BUG] - Only 1 filter per request is allowed [Enhancement] - Allow multiple filters per request May 8, 2022
@ddymko
Copy link
Contributor

ddymko commented May 8, 2022

@ribtoks We'll look into this for you

@ddymko
Copy link
Contributor

ddymko commented May 8, 2022

@ribtoks This error looks like it is coming back from API. We'll have to take a look at the API. I'll make an internal ticket to dig into this on the API side and get back to you.

@ribtoks
Copy link
Author

ribtoks commented May 8, 2022

@ddymko Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants