Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch coverage broken #327

Open
AlbertoCentonze opened this issue Oct 4, 2024 · 3 comments
Open

branch coverage broken #327

AlbertoCentonze opened this issue Oct 4, 2024 · 3 comments
Labels
bug Something isn't working prio - HIGH

Comments

@AlbertoCentonze
Copy link
Contributor

No description provided.

@heswithme
Copy link

heswithme commented Oct 4, 2024

Steps to reproduce:

1. Clone the repository and checkout the specific commit

git clone https://github.com/curvefi/stcrvusd.git
cd stcrvusd
git checkout 4ab93f23b83d37706375d6099fc3ace2df1f19bf

2. Set up Poetry with a local virtual environment

poetry config virtualenvs.in-project true
poetry install

3. Activate the virtual environment

source .venv/bin/activate

4. Run tests with coverage

pytest tests/unitary --cov= --cov-branch
coverage html
open htmlcov/index.html

Issue:

All if statements are marked as non-covered, despite tests hitting both branches.

image

@charles-cooper charles-cooper added bug Something isn't working prio - HIGH labels Oct 4, 2024
@DanielSchiavini
Copy link
Collaborator

@charles-cooper have you worked on this yet?

@charles-cooper
Copy link
Member

@charles-cooper have you worked on this yet?

haven't yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio - HIGH
Projects
None yet
Development

No branches or pull requests

4 participants