Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cocoapods #10

Closed
moh-abk opened this issue Aug 14, 2020 · 5 comments
Closed

Support cocoapods #10

moh-abk opened this issue Aug 14, 2020 · 5 comments
Assignees

Comments

@moh-abk
Copy link

moh-abk commented Aug 14, 2020

Due to this issue - https://forums.swift.org/t/swift-packages-in-multiple-targets-results-in-this-will-result-in-duplication-of-library-code-errors/34892/38 - SPM is kind of broken at the moment. It'll be great if this made it to cocoapods 😉

@vyshane vyshane self-assigned this Aug 18, 2020
@vyshane
Copy link
Owner

vyshane commented Aug 18, 2020

I've just pushed the new podspec.

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  CombineGRPC (0.16.0) successfully published
 📅  August 18th, 22:38
 🌎  https://cocoapods.org/pods/CombineGRPC
 👍  Tell your friends!
--------------------------------------------------------------------------------

Can you try to install it by adding the following to your Podfile?

pod 'CombineGRPC', '~> 0.16'

@moh-abk
Copy link
Author

moh-abk commented Aug 18, 2020

Awesome - just pulled it but it's not showing the source files.
Might be related to - https://github.com/vyshane/grpc-swift-combine/blob/master/CombineGRPC.podspec#L19

image

@vyshane
Copy link
Owner

vyshane commented Aug 20, 2020

Yikes. That was my first foray into creating a podspec. Thanks for spotting the issue. I've fixed it. However, it looks like we are blocked by an upstream issue grpc/grpc-swift#928.

@vyshane
Copy link
Owner

vyshane commented Sep 2, 2020

Upstream Swift gRPC have fixed their CocoaPod in release v1.0.0-alpha.19. I have updated the dependency in CombineGRPC and released v0.17.0. You can now install the pod by adding 'CombineGRPC', '~> 0.17' to your Podfile.

@moh-abk
Copy link
Author

moh-abk commented Sep 2, 2020

thanks @vyshane -- can confirm it works!

@moh-abk moh-abk closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants