Skip to content

Commit

Permalink
Change daptm:langSrc to use a BCP47 language code
Browse files Browse the repository at this point in the history
Resolves #148 as per TTWG discussion.
  • Loading branch information
nigelmegitt committed Sep 29, 2023
1 parent cd34f86 commit 426f706
Show file tree
Hide file tree
Showing 11 changed files with 74 additions and 58 deletions.
2 changes: 1 addition & 1 deletion examples/event-desc-descType.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<body>
<div begin="10s" end="13s">
<ttm:desc daptm:descType="pronunciationNote">[oːnʲ]</ttm:desc>
<p daptm:langSrc="original">Eóin looks around at the other assembly members.</p>
<p>Eóin looks around at the other assembly members.</p>
</div>
</body>
...
6 changes: 3 additions & 3 deletions examples/event-desc-multiple-descType.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
<p daptm:langSrc="original">
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc daptm:descType="scene">Scene 1</ttm:desc>
<ttm:desc daptm:descType="plotSignificance">Low</ttm:desc>
<p daptm:langSrc="original">
<p>
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
8 changes: 4 additions & 4 deletions examples/event-desc.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@
<body>
<div begin="10s" end="13s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p>
<span>A woman climbs into a small sailing boat.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>Une femme monte à bord d'un petit bateau à voile.</span>
</p>
</div>
<div begin="18s" end="20s">
<ttm:desc>Scene 1</ttm:desc>
<p daptm:langSrc="original">
<p>
<span>The woman pulls the tiller and the boat turns.</span>
</p>
<p xml:lang="fr" daptm:langSrc="translation">
<p xml:lang="fr" daptm:langSrc="en">
<span>La femme tire sur la barre et le bateau tourne.</span>
</p>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1" daptm:onScreen="ON_OFF">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr">
<span begin="0s">And thanks to that,</span><span begin="1.5s"> we're gonna get rich.</span>
</p>
</div>
Expand Down
4 changes: 2 additions & 2 deletions examples/intro-original-language-with-dub-language.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
</head>
<body>
<div begin="10s" end="13s" ttm:agent="character_1">
<p xml:lang="fr" daptm:langSrc="original">
<p xml:lang="fr">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
<p xml:lang="en" daptm:langSrc="translation">
<p xml:lang="en" daptm:langSrc="fr">
<span>And thanks to that, we're gonna get rich.</span>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-original-language.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</head>
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original" ttm:agent="character_1">
<p ttm:agent="character_1">
<span>Et c'est grâce à ça qu'on va devenir riches.</span>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-embedded-audio.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-gain.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
daptm:originalLang="en">
...
<div begin="25s" end="28s">
<p daptm:langSrc="original">
<p>
<animate begin="0.0s" end="0.3s" tta:gain="1;0.39" fill="freeze"/>
<animate begin="2.7s" end="3s" tta:gain="0.39;1"/>
<span begin="0.3s" end="2.7s">
Expand Down
2 changes: 1 addition & 1 deletion examples/intro-script-with-speak.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
...
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
<span tta:speak="normal">
The woman pulls the tiller and the boat turns.</span>
</p>
Expand Down
4 changes: 2 additions & 2 deletions examples/intro-times-and-text.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
daptm:originalLang="en">
<body>
<div begin="10s" end="13s">
<p daptm:langSrc="original">
<p>
A woman climbs into a small sailing boat.
</p>
</div>
<div begin="18s" end="20s">
<p daptm:langSrc="original">
<p>
The woman pulls the tiller and the boat turns.
</p>
</div>
Expand Down
96 changes: 56 additions & 40 deletions index.html

Large diffs are not rendered by default.

0 comments on commit 426f706

Please sign in to comment.