Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain better the convention for attributes with no namespace value #257

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Explain better the convention for attributes with no namespace value #257

merged 2 commits into from
Oct 11, 2024

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Oct 8, 2024 •
edited by pr-preview bot
Loading

Closes #250 by removing the term "global namespace" for attributes.

Preview | Diff

andreastai
andreastai reviewed Oct 8, 2024
View reviewed changes
Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Note that section 5.2.2 does also mention "global namespace"

@nigelmegitt nigelmegitt force-pushed the issue-0250-no-namespace-attributes branch from 5688c58 to 41010d0 Compare October 9, 2024 12:50
@nigelmegitt
Copy link
Contributor Author

Thanks again, fixed the other "global namespace" too.

@nigelmegitt nigelmegitt merged commit 4ecd681 into main Oct 11, 2024
2 checks passed
@nigelmegitt nigelmegitt deleted the issue-0250-no-namespace-attributes branch October 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreastai andreastai andreastai left review comments

@cconcolato cconcolato cconcolato approved these changes

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attributes with no namespace prefix are not in a global namespace
3 participants
@nigelmegitt @cconcolato @andreastai