Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we restrict remote resources to make validation easier? #1855

Closed
iherman opened this issue Oct 15, 2021 · 2 comments
Closed

Should we restrict remote resources to make validation easier? #1855

iherman opened this issue Oct 15, 2021 · 2 comments
Labels
Status-Duplicate The issue is a duplicate of another

Comments

@iherman
Copy link
Member

iherman commented Oct 15, 2021

Assuming we don't loosen the restriction, though, there probably are ways we could beef up validation. The simplest one might be to specify where remote resources are allowed, not just what types. So the wording, for example, could be "Audio resources when referenced from the audio element" or "Video resources when referenced from the video element."

That would allow epubcheck to more easily flag any remote resource referenced where it's not allowed, as it wouldn't have to know anything about its media type. It would also limit potential abuse, as you can't load a random resource into an audio or video element like you can with an iframe. This might also help with our security review, as there's less damage a remote resource can do from audio/video elements and a css font declaration. (Not sure how much it does for scripts being able to read in remote resources, though.)

Originally posted by @mattgarrish in #1061 (comment)

@iherman
Copy link
Member Author

iherman commented Oct 15, 2021

Oops, duplication of #1857, closing

@iherman iherman closed this as completed Oct 15, 2021
@mattgarrish
Copy link
Member

Weird, I must have gotten a cached page this morning as I didn't even see this. 1843 was still showing as the most recent issue, so I figured you'd left it for me to open.

@mattgarrish mattgarrish added the Status-Duplicate The issue is a duplicate of another label Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Duplicate The issue is a duplicate of another
Projects
None yet
Development

No branches or pull requests

2 participants