Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop automatically exposing details relation for figure -> figcaption #564

Open
aleventhal opened this issue Sep 25, 2024 · 7 comments · May be fixed by w3c/aria#2224
Open

Stop automatically exposing details relation for figure -> figcaption #564

aleventhal opened this issue Sep 25, 2024 · 7 comments · May be fixed by w3c/aria#2224

Comments

@aleventhal
Copy link
Collaborator

I thought we had filed this, so there may be a dupe somewhere.
We should stop automatically exposing the details relation between figure and figcaption. They are nearby in the DOM anyway. It was so noisy on some pages that it caused JAWS to stop reading details relation entirely.
@pkra
Copy link
Member

pkra commented Sep 26, 2024

I thought we had filed this, so there may be a dupe somewhere.

@aleventhal maybe you're thinking of w3c/aria#2224 ?

@aleventhal
Copy link
Collaborator Author

Thanks @pkra . I mentioned it in a comment in that PR. But it hasn't been changed in that PR. Should we keep it as a separate issue? Or do you want to add to that PR?

@scottaohara
Copy link
Member

scottaohara commented Sep 26, 2024 •
edited
Loading

i was planning on handling it in the PR - i've just not had the time. someone else can update the PR, otherwise it's on me to get it done - and i will as soon as i can.

i have updated the PR

@scottaohara
Copy link
Member

@aleventhal to be fair though, since the PR never landed because we've been waiting on other browser to implement, chromium should be fine to remove it even without the PR update.

@scottaohara
Copy link
Member

let's keep this issue open so it can come up in triage - and then this can be a reminder for people to re-review the PR so we can get it merged asap

aarongable pushed a commit to chromium/chromium that referenced this issue Sep 30, 2024
@aleventhal
[A11y] Do not automatically expose detailsIds for figcaption
7b4bb8d 
This was harmful because it caused JAWS to turn off details
announcements, because it was too verbose on certain
web pages. These elements are already close by in the DOM/a11y
tree so there is really no point in doing this.

See w3c/html-aam#564

Bug: none
Change-Id: I0be887c382dc3b6768571f3f8770312e619273a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891779
Commit-Queue: Benjamin Beaudry <[email protected]>
Reviewed-by: Benjamin Beaudry <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1361785}
@spectranaut spectranaut linked a pull request Nov 14, 2024 that will close this issue
Open
@spectranaut
Copy link
Contributor

Discussed in today's ARIA working group meeting: https://www.w3.org/2024/11/14-aria-minutes.html#d8ca

@aleventhal
Copy link
Collaborator Author

FWIW Chromium stopped doing this in milestone 131, to match other browsers. So we just need to make it official in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[html-aam PR 359] Change figure & figcaption accName computation w3c/aria
4 participants
@pkra @spectranaut @aleventhal @scottaohara