Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details dictionary parameters description could be more precise #321

Open
youennf opened this issue Feb 16, 2024 · 1 comment
Open

Details dictionary parameters description could be more precise #321

youennf opened this issue Feb 16, 2024 · 1 comment
Labels

Comments

@youennf
Copy link
Contributor

youennf commented Feb 16, 2024

The seekOffset dictionary member is the time in seconds to move the playback time by. If present, it should always be positive.

Should we change should always to MUST?

The fastSeek dictionary member will be true if the seek action is being called multiple times as part of a sequence and this is not the last call in that sequence.

The sentence is not mandating to use false (or undefined?) for the last call in the sequence.
We have true, false and undefined possible values.
Should we only have true and false and make the member required?

@chrisn
Copy link
Member

chrisn commented May 9, 2024

For seekOffset, changing to a MUST sounds reasonable. Why would an implementation provide a zero value?

For fastSeek, in which circumstances might this member not be present? The current spec language suggests it's always present so should indeed be required.

@chrisn chrisn added the P1 label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants