Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaSessionActionHandler callback's type is never correctly chosen #331

Open
marcoscaceres opened this issue May 13, 2024 · 2 comments
Open

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented May 13, 2024

The spec says:

<li>
  Run <var>handler</var> with the <var>details</var> parameter set to:
  {{MediaSessionActionDetails}}.
</li>

But the actual dictionary type is never selected. It needs to match the action, and that dictionary should be properly initialized.

@marcoscaceres
Copy link
Member Author

The problem is that it's not wired up correctly.

This:

The MediaSessionActionHandler MUST be run with the details parameter whose dictionary type is:

Should be moved to the where the actual callback handler is called. This should really be a switch statement based on the action type.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented May 13, 2024

Further, for example, MediaSessionSeekToActionDetails:

dictionary MediaSessionSeekToActionDetails : MediaSessionActionDetails {   
  required double seekTime;   
   boolean fastSeek; 
};

The spec never says what to set .seekTime to, or what .fastSeek should be set to. It just provides a description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant