Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define more style properties [meta issue] #283

Open
adrianholovaty opened this issue May 10, 2022 · 2 comments
Open

Define more style properties [meta issue] #283

adrianholovaty opened this issue May 10, 2022 · 2 comments

Comments

@adrianholovaty
Copy link
Contributor

adrianholovaty commented May 10, 2022

This is a meta issue to hold discussion about style properties we should add, now that #263 (and #282) have added styling to the MNX spec. At the moment, we've deliberately only defined one style property, color, in order to keep focused on getting the infrastructure right.

Now that the infrastructure is set up, we should get to work defining other style properties. Here is a relevant snippet from @joeberkovitz's comment on #263:

Here are some possible examples that illustrate the variety of possible styles:

color
stem orientation
note head size
music or text font family
fine-grained X/Y offsets
visibility / audibility
enharmonic spelling variants

What are the must-have styles for MNX 1.0? Let's have a "meta" discussion on this issue, then open separate, individual issues for each agreed-on style property.

To start the discussion, I'll propose "music font family". This seems non-controversial and is definitely table stakes for music styling.

@adrianholovaty adrianholovaty changed the title Define more style properties [meta issue Define more style properties [meta issue] May 10, 2022
@mdgood
Copy link

mdgood commented May 10, 2022

We might want to broaden the discussion of music font family to more general music and text font properties. There are some interesting design choices there that come up in the larger context.

@clnoel
Copy link

clnoel commented May 16, 2022

In my opinion, the music font is the thing most likely to be ignored when importing a piece of music. Everybody is going to want to use their own font after they finish importing. At Musicnotes, we have two proprietary music fonts and all our pieces are published in those, regardless of what the source was. Text font is slightly more useful, as size, italics, bolding, etc. should be respected even if the exact specified font is not used.

However, I would like to start with something that is more likely to affect the way the imported music is shown, such as stem orientation, stem length, x/y offsets, or note-head size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants