-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move rdf1.1 change note boxes to change section in appendix #79
base: main
Are you sure you want to change the base?
Conversation
@pchampin Do you know why the auto-publish is failing? |
See the job log - https://github.com/w3c/rdf-semantics/actions/runs/13185386283/job/36806138521?pr=79#step:3:985
|
Thanks |
|
||
<li>In the RDF 1.0 specification, | ||
datatype D-entailment was defined as a <a>semantic extension</a> of RDFS-entailment. | ||
In RDF 1.1 it was defined as a direct extension to basic RDF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In RDF 1.1 it was defined as a direct extension to basic RDF. | |
In RDF 1.1, it was defined as a direct extension to basic RDF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not view this as a desirable change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfps — What's your argument against adding this comma? Perhaps my reason for adding it will be made clearer if you look at the preceding sentence, which starts In the RDF 1.0 specification,
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an editor I feel that this change isn't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the comma from the previous sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the correct choice. The "In RDF 1.1
" and "In the RDF 1.0 specification
" are each an independent clause, and should be followed by a comma when they start the sentence. They could be moved to the end where they need not be preceded by a comma (e.g., Datatype D-entailment was defined as a <a>semantic extension</a> of RDFS-entailment in the RDF 1.0 specification. It was defined as a direct extension to basic RDF in RDF 1.1.
), but this would make the meanings of the sentences less clear.
spec/index.html
Outdated
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology, | ||
the longer phrasing "simple D-entailment" or "simple datatype entailment" | ||
should be used rather than "D-entailment". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology, | |
the longer phrasing "simple D-entailment" or "simple datatype entailment" | |
should be used rather than "D-entailment". | |
If needed, RDF 1.1's longer phrasing of "simple D-entailment" or "simple | |
datatype entailment" can be used to distinguish from RDF 1.0's shorter | |
"D-entailment" terminology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not view this as a desirable change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also a little bit confused by this change: It reads like the term "D-entailment" is only present in RDF 1.0, but that is not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence should probably be modified to not be specific to 1.1. I've put in a suggestion for this.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with all the changes, but think that the last suggestion of Ted adds confusion.
I leave the discussion of commas to the native speakers :)
and introduced the special type | ||
<a data-cite="RDF12-CONCEPTS#dfn-language-tagged-string"><code>rdf:langString</code></a> | ||
for language-tagged strings. | ||
The full semantics for typed literals is given in section [[[#datatypes]]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether the sentence "The full semantics for typed literals is given in section [[[#datatypes]]]." is needed. We describe changes between RDF 1.0 and RDF 1.1 and now link to the section in RDF 1.2?
spec/index.html
Outdated
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology, | ||
the longer phrasing "simple D-entailment" or "simple datatype entailment" | ||
should be used rather than "D-entailment". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence should probably be modified to not be specific to 1.1. I've put in a suggestion for this.
The full semantics for typed literals is given in section [[[#datatypes]]]. | ||
</li> | ||
|
||
<li>In the RDF 1.0 specification, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>In the RDF 1.0 specification, | |
<li>In the RDF 1.0 specification |
Fixes #62
Preview | Diff