Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rdf1.1 change note boxes to change section in appendix #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pfps
Copy link
Contributor

@pfps pfps commented Feb 6, 2025

Fixes #62


Preview | Diff

@pfps pfps requested review from afs and doerthe February 6, 2025 18:24
@pfps
Copy link
Contributor Author

pfps commented Feb 6, 2025

@pchampin Do you know why the auto-publish is failing?

@afs
Copy link
Contributor

afs commented Feb 6, 2025

Do you know why the auto-publish is failing?

See the job log - https://github.com/w3c/rdf-semantics/actions/runs/13185386283/job/36806138521?pr=79#step:3:985

Validate markup
  Validating index.html...
  $ pnpm add vnu-jar
  + vnu-jar 24.10.17
  $ java -jar "/home/runner/work/_actions/w3c/spec-prod/v2/node_modules/.pnpm/[email protected]/node_modules/vnu-jar/build/dist/vnu.jar" --also-check-css index.html
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3336.7-3338.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3340.7-3342.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3344.7-3348.21: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3348.22-3348.27: error: Element “code” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3348.41-3350.6: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3350.7-3350.131: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3350.163-3352.64: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3352.65-3352.138: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3352.193-3353.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3355.7-3356.43: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3356.44-3356.157: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3356.180-3363.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3365.7-3366.9: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3366.10-3366.110: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3366.127-3369.24: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3369.25-3370.63: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3370.64-3370.164: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3370.181-3371.18: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3371.19-3371.130: error: Element “dfn” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3371.149-3372.21: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3372.22-3372.130: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3372.151-3373.67: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3373.68-3373.168: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3373.186-3375.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3378.7-3380.8: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3380.9-3380.121: error: Element “a” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3380.144-3381.2: error: Text not allowed in element “ul” in this context.
    "file:/home/runner/work/rdf-semantics/rdf-semantics.w3c/spec/index.html":3383.7-3385.2: error: Text not allowed in element “ul” in this context.
  ❌  Not so good... please fix the issues above.
  Error: Process completed with exit code 1.

@pfps
Copy link
Contributor Author

pfps commented Feb 6, 2025

Thanks

@pfps pfps added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Feb 6, 2025

<li>In the RDF 1.0 specification,
datatype D-entailment was defined as a <a>semantic extension</a> of RDFS-entailment.
In RDF 1.1 it was defined as a direct extension to basic RDF.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In RDF 1.1 it was defined as a direct extension to basic RDF.
In RDF 1.1, it was defined as a direct extension to basic RDF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not view this as a desirable change.

Copy link
Member

@TallTed TallTed Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfps — What's your argument against adding this comma? Perhaps my reason for adding it will be made clearer if you look at the preceding sentence, which starts In the RDF 1.0 specification,.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an editor I feel that this change isn't needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the comma from the previous sentence.

Copy link
Member

@TallTed TallTed Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the correct choice. The "In RDF 1.1" and "In the RDF 1.0 specification" are each an independent clause, and should be followed by a comma when they start the sentence. They could be moved to the end where they need not be preceded by a comma (e.g., Datatype D-entailment was defined as a <a>semantic extension</a> of RDFS-entailment in the RDF 1.0 specification. It was defined as a direct extension to basic RDF in RDF 1.1.), but this would make the meanings of the sentences less clear.

spec/index.html Outdated
Comment on lines 2236 to 2238
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology,
the longer phrasing "simple D-entailment" or "simple datatype entailment"
should be used rather than "D-entailment".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology,
the longer phrasing "simple D-entailment" or "simple datatype entailment"
should be used rather than "D-entailment".
If needed, RDF 1.1's longer phrasing of "simple D-entailment" or "simple
datatype entailment" can be used to distinguish from RDF 1.0's shorter
"D-entailment" terminology.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not view this as a desirable change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also a little bit confused by this change: It reads like the term "D-entailment" is only present in RDF 1.0, but that is not the case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence should probably be modified to not be specific to 1.1. I've put in a suggestion for this.

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Copy link
Contributor

@doerthe doerthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with all the changes, but think that the last suggestion of Ted adds confusion.
I leave the discussion of commas to the native speakers :)

and introduced the special type
<a data-cite="RDF12-CONCEPTS#dfn-language-tagged-string"><code>rdf:langString</code></a>
for language-tagged strings.
The full semantics for typed literals is given in section [[[#datatypes]]].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the sentence "The full semantics for typed literals is given in section [[[#datatypes]]]." is needed. We describe changes between RDF 1.0 and RDF 1.1 and now link to the section in RDF 1.2?

spec/index.html Outdated
Comment on lines 2236 to 2238
If there is a need to distinguish RDF 1.1 from the RDF 1.0 terminology,
the longer phrasing "simple D-entailment" or "simple datatype entailment"
should be used rather than "D-entailment".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence should probably be modified to not be specific to 1.1. I've put in a suggestion for this.

The full semantics for typed literals is given in section [[[#datatypes]]].
</li>

<li>In the RDF 1.0 specification,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>In the RDF 1.0 specification,
<li>In the RDF 1.0 specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update change notes
4 participants