Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonWebKey definition in Data Integrity #130

Closed
msporny opened this issue Jul 28, 2023 · 3 comments
Closed

Add JsonWebKey definition in Data Integrity #130

msporny opened this issue Jul 28, 2023 · 3 comments
Assignees
@msporny
Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.

Comments

@msporny
Copy link
Member

msporny commented Jul 28, 2023

Since the JsonWebSignature2020 specification has been pulled, we need to define JsonWebKey so that implementers can use it if they so choose to use publicKeyJwk. This is just a tracking issue to make sure we do that.
@msporny msporny added ready for pr This issue is ready to be resolved via a pull request before CR This issue needs to be resolved before the Candidate Recommendation phase. labels Jul 28, 2023
@msporny msporny assigned msporny and unassigned dmitrizagidulin Jul 29, 2023
@msporny msporny mentioned this issue Jul 29, 2023
Merged
@msporny
Copy link
Member Author

msporny commented Jul 29, 2023

Sorry, @dmitrizagidulin -- you were assigned to this, I was addressing issue #73 and accidentally ended up writing the PR for this issue in the process.

@msporny
Copy link
Member Author

msporny commented Jul 29, 2023

PR #135 has been raised to address this issue. This issue will be closed once #135 is merged.

@msporny msporny added pr exists A pull request exists to address this issue. and removed ready for pr This issue is ready to be resolved via a pull request labels Jul 29, 2023
@msporny
Copy link
Member Author

msporny commented Aug 12, 2023

PR #135 has been merged, closing.

@msporny msporny closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @dmitrizagidulin