Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revoked and expired to verification method classes #1262

Closed
OR13 opened this issue Aug 28, 2023 · 9 comments
Closed

Add revoked and expired to verification method classes #1262

OR13 opened this issue Aug 28, 2023 · 9 comments
Labels
pending close Close if no objection within 7 days

Comments

@OR13
Copy link
Contributor

OR13 commented Aug 28, 2023

We need to update the vocabulary and contexts to align Multikey and JsonWebKey.

Once w3c/vc-data-integrity#184 (review) is merged, we will need to update the core contexts.

@iherman
Copy link
Member

iherman commented Aug 28, 2023

Can you be more explicit @OR13 ? #184 already includes a change in the vocabulary, namely that the domain expired is set to both (i.e., the union) of Proof and VerificationMethod. Should revoked be treated the same way (I was actually wondering about that)?

@OR13
Copy link
Contributor Author

OR13 commented Aug 28, 2023

@iherman I filed this to track the request from @msporny #1260 (review)

And yes! thats why I filed the issue, we should address revoked and expired and publicKeyMultibase / publicKeyJwk consistently.

I also fear that revoked and status lists will be confused, and we might use the vocabulary to help remove that confusion.

@dlongley
Copy link
Contributor

dlongley commented Aug 29, 2023

@iherman,

...the domain expired is set to both (i.e., the union) of Proof and VerificationMethod. Should revoked be treated the same way (I was actually wondering about that)?

It doesn't really make sense to add revoked to a Proof as it would require generating a new proof to do it. Proofs / VCs in that sense need to be tracked via some other status mechanism like StatusList.

@Sakurann Sakurann added ready for PR This issue is ready for a Pull Request to be created to resolve it before-CR and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Aug 29, 2023
@OR13
Copy link
Contributor Author

OR13 commented Sep 1, 2023

@dlongley i'm confused by your comment... perhaps its related "casing" being the only difference between verificationMethod and VerificationMethod ?

My original comment was on VerificationMethod -> MultiKey having "revoked", but VerifiableCredential -> CredentialStatus having a "status" of "revoked".

@dlongley
Copy link
Contributor

dlongley commented Sep 1, 2023

@OR13

Sorry, my comment was in response to Ivan. I'll edit that to make it clear.

@iherman
Copy link
Member

iherman commented Sep 2, 2023

@iherman,

...the domain expired is set to both (i.e., the union) of Proof and VerificationMethod. Should revoked be treated the same way (I was actually wondering about that)?

It doesn't really make sense to add revoked to a Proof as it would require generating a new proof to do it. Proofs / VCs in that sense need to be tracked via some other status mechanism like StatusList.

Fine with me. This is moot then.

@iherman
Copy link
Member

iherman commented Sep 3, 2023

The issue was discussed in a meeting on 2023-08-29

  • no resolutions were taken
View the transcript

2.2. Add revoked and expired to verification method classes (issue vc-data-model#1262)

See github issue vc-data-model#1262.

David Waite: kristina, TallTed: mark as discuss.

Manu Sporny: Orie noticed that JWK didn't have the expired and revoked properties that multikey had.
… alignment would mean JWK would have all the same properties.
… being aligned in DI, after that may need to be aligned in base context.
… may be able to do it post-CR since the context can be modified, but not preferred.


@iherman
Copy link
Member

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

2.4. Add revoked and expired to verification method classes (issue vc-data-model#1262)

See github issue vc-data-model#1262.

Brent Zundel: next issue: 1262. add revoked and expired to verificationMethod classes.
� been conversation, but no one assigned. can anyone give a summary.

Manu Sporny: there was a misalignment in the data integrity between multikey and jsonwebkey.
� we've added those properties to json web key. now the same properties.
� so that's fixed in DI, but we think Orie wanted that change reflected into the base context.
� it is unlikely that that PR is going to be merged. The one that defines those keys.
� as a result, this issue is a bit moot.
� If we don't define the RDF classes for JWK and multikey in the base context (and we aren't), then we don't need to do anything with this issue.
� and the misalignment has been fixed in data integrity.

Brent Zundel: sounds like once that PR is closed, this issue should be closed.

Manu Sporny: i believe so, but we need to check if Orie agrees.

Brent Zundel: having closed that PR. we should close this one. (after checking that we did in fact do that).
� any opposition to adding Pending-Close on this issue?
� hearing none. I'm going to add the tag.

@brentzundel
Copy link
Member

no objections raised since marked pending close, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Close if no objection within 7 days
Projects
None yet
Development

No branches or pull requests

5 participants