-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issuee definition #1467
Comments
Here is the straw man proposal for the definition of issuee, so that we can discuss it here and then move the agreed upon definition to the PR #1468
And here is the straw man proposal for changing the definition of issuer.
|
The issue was discussed in a meeting on 2024-04-03
View the transcript2.4. Add issuee definition (issue vc-data-model#1467)See github issue vc-data-model#1467. David Chadwick: Yes. One of the issues, is does the issuer issue the credential directly or indirectly? Ted Thibodeau Jr.: I think that's a different discussion. Should be a different issue and we can talk about it on its own. Manu Sporny: One of the concerns I have about adding terminology is that it becomes harder for people to talk about the system.
Manu Sporny: if we add to many special terms it harms adoption because its harder to explain what we are doing.
Ivan Herman: I feel uneasy about the whole discussion. Gabe Cohen: I see a label of CR1. Ivan Herman: non-normative language is fine, but normative language can be in a second CR but still needs a good reason. But I'm not the technical expert. Gabe Cohen: I think with the new issue, we might benefit from seeing where the discussion might lead. Dave Longley: I don't think the current text has any issues wrt direct/indirect language. It was the potential introduction of issuee where that created potential problems.
Joe Andrieu: not a big fan of introducing issuee in a way that confuses the three primary roles...we talk about it at a high level and also subclassing. we know it is the holder who is presenting. we can talk about these distinctions (when the holder receives, presents)...
David Chadwick: As a result, I already removed it from the diagram. Gabe Cohen: Thanks, David. Everyone, please chime in on the issue. |
The issue was discussed in a meeting on 2024-04-03
View the transcript2.3. Add definition of Issuee (pr vc-data-model#1468)See github pull request vc-data-model#1468. David Chadwick: Heads up. The PR exists for the issuee property, but Ted asked to move the discussion back to the issue. Ivan Herman: can you add the issue reference in the minutes? David Chadwick: 1467. See github issue vc-data-model#1467. Gabe Cohen: might be useful to add a comment to the PR stating that. David Chadwick: It's there, but it's buried in the middle. Ted Thibodeau Jr.: let's talk about in the issue, then we implement it in the PR (or in a new PR), which likely would be different. Gabe Cohen: David would you like to discuss this? |
I think you're right about jamming two nouns together. However, I think we can change one of those nouns into a verb which can then serve as an adjective, e.g., "presenting holder" or "receiving holder", and these compound nouns can then provide some additional clarity in discussion of the passage of a VC/VP. |
@TallTed Thankyou for doing the search. Would you like to suggest changes to the straw man text above? |
This is a blend of the
I think no changes will be needed to the definition of I also think I also think that we need definition input and buy-in from more than just you and I, if this is to get into the document. |
While there is obviously interest from some parties to continue exploring an We discussed it rather thoroughly in #942 and could not find consensus, which led to that issue being closed. I believe this issue and the related PR #1468 should be closed. |
The issue was discussed in a meeting on 2024-04-10
View the transcript2.6. Add issuee definition (issue vc-data-model#1467)See github issue vc-data-model#1467. See github pull request vc-data-model#1468. Brent Zundel: ok, we're at time, thanks everyone. |
@TallTed I agree with most of your text, apart from this
Q. Is a holder required to store the VC in its repository? If not, how is it a holder? If it is, since an issuee is a subclass of a holder then it must also be required to store the VC in its repository |
@brentzundel This issue is still being discussed. It is not unusual for an issue to only have a couple of people discussing it, and it should not be closed until they have come to a resolution. So can I kindly ask you to keep the issue open until a resolution has been found, which can then be presented to the WG. |
Where do we say that a (struck out portions moved to #1475)
As to the answer to my question, I find that the latter definition includes "Holders store their credentials in credential repositories." This does not read to me as a requirement (since there's no MUST, nor even a SHOULD). (struck out portions moved to #1475) |
This issue has been discussed very thoroughly, primarily in issue #942, which was closed due to lack of consensus to make the change. |
@brentzundel This discussion is valuable as it is revealing other issues in our definitions besides the omission of issuee. For example see #1475 . So please do not close this until all the issues have been teased out and resolved as your statement "This new discussion does not introduce any new data" is not correct. |
We need to revisit the definition of holder to determine whether a holder must store verifiable credentials or not. If not, what does it mean to be a holder if you do not store VCs in a credential repository? What are you holding? |
Rather than closing this issue, I am marking it as |
@brentzundel Thankyou. When @TallTed and myself agree on some text we can forward it to the WG for consideration. |
Now that we have updated the definitions of holder, issuer and verifier, the addition of issuee becomes trivial. Specifically we simply change the definition of issuer from
to
The definition of issuee then simply becomes
|
There have been a number of discussions and pieces of text when the use of the term holder has not been precise enough, since it is the first holder that is specifically being addressed in these cases, rather than any holder.
The proposal is to add the definition of issuee to the data model, it being the first holder that the issuer issues the VC to.
The proposal is also to review the various CRs from the group and to use the newly defined term where it is appropriate to do so (rather than the existing use of holder, or first holder or other phrase that implies the issuee).
This will be a non-normative change to the DM, since there will not be any protocol messages that refer to the issuee.
The text was updated successfully, but these errors were encountered: