Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA-SD-2023: empty mandatory and selective pointers tests #46

Open
filip26 opened this issue Feb 27, 2024 · 2 comments
Open

ECDSA-SD-2023: empty mandatory and selective pointers tests #46

filip26 opened this issue Feb 27, 2024 · 2 comments

Comments

@filip26
Copy link

filip26 commented Feb 27, 2024

Hi,
please consider testing corner cases when pointers are empty/null. The tests could show real maturity/stability of an implementation.

  1. Issuer.sign - empty/null mandatory pointers
    An implementation should return a base proof with no mandatory/always disclosed/ data.

  2. Holder.derive - base proof from 1. + empty/null selective pointers
    An implementation should fail, as there is nothing to disclose. @Wind4Greg please can you confirm? Thank you!

  3. Holder.derive - base having mandatory pointers + empty/null selective pointers
    An implementation should return a derived proof disclosing only mandatory data.

@Wind4Greg
Copy link

@filip26 good cases. I think you found an error in my server side checks. I was rejecting the case with nothing selected but forgot that there could be mandatory reveal information.

I've gotten some requests to update the spec test vectors with something a bit more relevant than fictional windsurfing races. Also the longer test cases from @aljones15 helped me find a bug in my primitives so I'm going to try to come up with something more relevant for the spec and something longer and a bit more realistic for adding here. Ideas are welcome.

@aljones15
Copy link
Contributor

@filip26 I'm not aware of a normative statement for empty mandatoryPointers and selectiveDisclosure in the spec, but this is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants