Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize the jsonSchema property in the VCDM vocabulary? #206

Closed
iherman opened this issue Aug 18, 2023 · 5 comments · Fixed by #211
Closed

Formalize the jsonSchema property in the VCDM vocabulary? #206

iherman opened this issue Aug 18, 2023 · 5 comments · Fixed by #211
Assignees
Labels

Comments

@iherman
Copy link
Member

iherman commented Aug 18, 2023

In my reading the JsonSchemaCredential mechanism relies on, among other things, on a property called jsonSchema that must be added to the credential vocabulary. If that is correct, there should be an anchor which can be used from the vocabulary as a formal definition (at the moment, the only thing I saw is a table entry in §2.2. Also, my reading of the text is that the domain of the vocabulary should be JsonSchema (that class already exists) and the range should be rdf:JSON, meaning that the value is a piece of JSON that is opaque to any JSON-LD processing.

If that is indeed the case, I am happy to create a PR in the VCDM repository with that extension of the vocabulary as soon as I get a stable anchor in the spec that I can rely on.

cc @msporny @andresuribe87 @decentralgabe

@iherman iherman self-assigned this Aug 18, 2023
@iherman iherman added the pre-cr label Aug 18, 2023
@andresuribe87
Copy link
Collaborator

@iherman I was under the impression that w3c/vc-data-model#1215 was addressing this. Are you saying that we need to make more updates?

@decentralgabe
Copy link
Collaborator

@andresuribe87 I thought so too..but maybe what @iherman is saying is that while that change addressed the context, it did not address the vocab. So we need another entry here?

But I am not sure how to make it not conflict with the existing term

@iherman
Copy link
Member Author

iherman commented Aug 19, 2023

@decentralgabe,

@andresuribe87 I thought so too..but maybe what @iherman is saying is that while that change addressed the context, it did not address the vocab. So we need another entry here?

Exactly. Well, not necessary at that line in the file, but the point is that it should be added to the vocabulary.

But I am not sure how to make it not conflict with the existing term

Let that be my job :-)

But, if you look at the various terms in that file, there is a pointer back to the specifiation that could be considered as the place where the term is defined. So, for example, the classes the vocabulary refers back to the relevant sections, like https://www.w3.org/TR/vc-json-schema/#jsonschema. However, I would need such a URL that specifically points to the property jsonSchema (as opposed to the class JsonSchema).

Once I have that, I can take it over.

@iherman
Copy link
Member Author

iherman commented Sep 4, 2023

Where are we with this? I would hate to be in the status of endlessly waiting for one another...

From where I stand: I need a reasonable anchor for the property jsonShema, ie, a place in the text that can be considered as the definition of that property, and that definition should have a proper fragment URL in the spec.

Once that anchor is added in this repository, I can "take over" and add that missing property to the credential vocabulary.

@decentralgabe
Copy link
Collaborator

@iherman please review #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants