Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode example syntax #2165

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix Unicode example syntax #2165

merged 1 commit into from
Oct 7, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 1, 2024

Fixes #1641 as proposed in the issue.


Preview | Diff

@emlun emlun added type:editorial i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. labels Oct 1, 2024
@emlun emlun requested a review from aphillips October 1, 2024 12:54
Copy link

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought you were removing this section?

@aphillips aphillips removed the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Oct 1, 2024
@aphillips
Copy link

I removed the i18n-needs-resolution tag. The issue (#1641 in this case) tracks closure. There's no need to tag your PRs.

@emlun
Copy link
Member Author

emlun commented Oct 1, 2024

I thought you were removing this section?

Maybe, but just in case we don't. This wasn't actually that much effort either way.

@emlun
Copy link
Member Author

emlun commented Oct 2, 2024

2024-10-02 WG call: @aphillips has approved, good to merge.

@emlun
Copy link
Member Author

emlun commented Oct 2, 2024

(Tagging editors for review as I need at least one approval to proceed to merge)

@emlun emlun merged commit 386ad79 into main Oct 7, 2024
2 checks passed
@emlun emlun deleted the issue-1641-unicode-syntax branch October 7, 2024 12:34
github-actions bot added a commit that referenced this pull request Oct 7, 2024
SHA: 386ad79
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to emlun/webauthn that referenced this pull request Oct 7, 2024
SHA: 386ad79
Reason: push, by emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

U+ notation incorrect
4 participants