Allow level-id to be different in codec match #3023
Conversation
|
@aboba Does this wording make sense to you? |
webrtc.html
Outdated
| <code>false</code>. Two FMTP lines are the same as long as they convey the same | ||
| information, including omitting parameters with well defined defaults or using | ||
| different order. In this step, the user agent MUST consider two FMTP lines | ||
| identical if the "media format" are the same but the highest complying bitstream |
There was a problem hiding this comment.
| identical if the "media format" are the same but the highest complying bitstream | |
| identical if the "media format" is the same but the highest complying bitstream |
There was a problem hiding this comment.
calling them "identical" if the information is the same but they differ is a bit confusing, no?
There was a problem hiding this comment.
The text is ambiguous because not all fmtp parameters are included in the "media format" for matching purposes. As an example, the statement applies to H.265 but not H.264 where profile-level-id combines profile with level-id.
|
if you want to go this route you will also need to take care of RFC6184s |
No this is just about the codec matching algorithm used to sanity check input to setParameters/setCodecPreferences, what is actually negotiated based on this is defined somewhere else. As for sending the selected codec, the description is kind of vague, RTCRtpEncodingParmaters.codec just says:
And setParameters just says:
So it's just "codec used for selecting what to send", we might want to create an issue about clarifying not to send greater than the level-id that was negotiated, but that seems more like an editorial note. |
We might want to update getParameters().encodings[i].codec to match the level-id that you find in getParamters().codecs though? Separate issue though because that is the same as what happens with setCodecPreferences() today |
| <p> | ||
| If either (but not both) of <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}} | ||
| and <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}} are [= map/exist | missing =], | ||
| or if they both [=map/exist=] and <var>first</var>.{{RTCRtpCodec/sdpFmtpLine}} | ||
| is different from <var>second</var>.{{RTCRtpCodec/sdpFmtpLine}}, return | ||
| <code>false</code>. | ||
| <code>false</code>. Two FMTP lines are the same as long as they convey the same | ||
| information, including omitting parameters with well defined defaults or using |
There was a problem hiding this comment.
Change "information" to "media format", which is codec specific.
There was a problem hiding this comment.
Try to align spec language with CL :)
| "difftype": "modify", | ||
| "id": 51, | ||
| "pr": 3023, | ||
| "testUpdates": "not-testable" |
There was a problem hiding this comment.
Remote SDP is testable.
Fixes #3020
Preview | Diff