Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MTU via stats #615

Open
vasilvv opened this issue Sep 9, 2024 · 2 comments
Open

Expose MTU via stats #615

vasilvv opened this issue Sep 9, 2024 · 2 comments

Comments

@vasilvv
Copy link
Contributor

vasilvv commented Sep 9, 2024

Currently we provide a bandwidth measurement, but it includes framing overhead, making it hard to use for applications.

In general, we should be able to approximate the overhead as MTU - maxDatagramSize, so knowing the MTU would be helpful.

@wilaw wilaw added the Discuss at next meeting Flags an issue to be discussed at the next WG working label Sep 10, 2024
@wilaw wilaw added this to the Candidate Recommendation milestone Sep 23, 2024
@wilaw
Copy link
Contributor

wilaw commented Oct 7, 2024

Discussed at TPAC:
Expose MTU via stats#615
JIB explained why we need a MTU stat.
Eric - first reaction, fine, however, estimatedSendrate should be saying this is how much of your data can get across this pipe. Shouldn’t we tell you the estimated bandwidth that is useful for you? We should adjust estimateSendrate.
Cullen - wouldn't the right number differ with small or large packets?
Eric - we agree that it’s really complicated
Lucas - not strong opinion, what overhead are we talking about? Thresholds jump around. People shouldn’t rely precisely on this data.
Mirja - what is the use case here?
Eric - our estimatedSendRate is a hint to which you can set your encoder. Is exposing current MTU a privacy feature?
Harald - if MTU has a surprising value, it’s good to know.
David - is this worth the agony? It’s always going to be slightly off.
JIB - not hearing too much support for caring.
Mirja - rename to max?
Eric - we could adjust estimateSendRate and do the math for users.
Conclusion: no consensus. Need to readdress issue in bi-weekly calls.

@jan-ivar
Copy link
Member

Meeting:

  • Can we state the estimatedSendRate excludes overhead instead? I.e. a payload number.
  • IOW include the overhead in the calculation to return an estimate of the ceiling without it
  • This should address the concern and not need a new stat

@jan-ivar jan-ivar added Ready for PR and removed Discuss at next meeting Flags an issue to be discussed at the next WG working labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants