Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make SSE informative? #417

Closed
mmccool opened this issue Sep 26, 2022 · 3 comments
Closed

Should we make SSE informative? #417

mmccool opened this issue Sep 26, 2022 · 3 comments

Comments

@mmccool
Copy link
Contributor

mmccool commented Sep 26, 2022

See w3c/wot-profile#397

Should we keep SSE (and the Event API) as normative, or make it informative? Not clear we have sufficient implementation experience. We do have two implementations, but they are both servers. Unfortunately we don't have clients to test these with.

@mmccool
Copy link
Contributor Author

mmccool commented Sep 26, 2022

Let's FORCE these assertions/section (Events API) as being as at-risk, so that we CAN take them out of the PR.

@relu91
Copy link
Member

relu91 commented Sep 26, 2022

Just to clarify some points in w3c/wot-profile#397:

we currently don't have client implementations - in theory, node-wot and Node-RED could implement, however.

Node-wot has already a client implementation (even the server side is implemented but I think it is not relevant)

make events informative; current SSE implementations incomplete, and retention is a problem (needs custom impl).

This is not entirely true; unless I missed something, Zion implementation should be complete. However, I agree that retention has scalability issues. We implemented a "placeholder* strategy because we were worried about retaining all the events forever, probably we just need a best-effort approach (i.e. is not guaranteed that the TDD will give back all the events you missed). In my understanding, the SSE Specification does not oblige you to keep track of all the events that happened in the past.

p.s. sorry for missing today's discussion.

@mmccool
Copy link
Contributor Author

mmccool commented Mar 27, 2023

So the CR publication includes the SSE assertions; unfortunately, we did NOT force them to be marked as at-risk. That means we are now committed to those assertions, and I propose closing this issue as "resolved". However, while ok on a LAN, SSE is not great for cloud services, not being very scalable, so I'll create another issue (see #468) to look at alternative event mechanisms in Discovery 2.0 (e.g. web hooks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants