Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP34 Transfer event parameter "from" is unnecessary #69

Open
Nradko opened this issue Feb 20, 2024 · 1 comment
Open

PSP34 Transfer event parameter "from" is unnecessary #69

Nradko opened this issue Feb 20, 2024 · 1 comment

Comments

@Nradko
Copy link

Nradko commented Feb 20, 2024

In PSP34 the Transfer event possesses field "from" that is unnecessary.

One can always deduce the previous owner of a token with an ID based on the previous Transfer event that contains the ID.
If such a previous event doesn't exist it means that the token hasn't been minted.

I would recommend changing the standard. Changes to events should not break the cross-contract calls. Also If one assumes the new standard in one's off-chain application the application will be compatible with the previous standard as long as one allows the field "from" to be undefined.

@Nradko Nradko changed the title PSP34 Transfer event from parameter is unnecessary PSP34 Transfer event parameter "from" is unnecessary Feb 20, 2024
@deuszx
Copy link

deuszx commented Feb 21, 2024

I have to disagree that it's unnecessary. Events are often observed in isolation so information about past events are not readily available. Not all indexers/event listeners have access to the previous Transfer event that could have happened months/years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants