Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serialization of Publickey and Signature #42

Open
drskalman opened this issue Feb 16, 2022 · 2 comments
Open

Improve serialization of Publickey and Signature #42

drskalman opened this issue Feb 16, 2022 · 2 comments
Assignees

Comments

@drskalman
Copy link
Collaborator

arkworks now have serialization for projective curve, so we should use it.

@drskalman drskalman self-assigned this Feb 16, 2022
@drskalman
Copy link
Collaborator Author

ffbcbff derive serialization and impl ToBytes FromBytes from arkworks. Tests should be adapted to use ToBytes FromBytes. The compromise is that to bytes and from bytes do not return constant length arrays. But that was broken and hardcoded for 384 bytes.

@burdges
Copy link
Collaborator

burdges commented Feb 24, 2022

Avoid To/FromBytes: arkworks-rs/algebra#390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants