Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker containerd format fails to parse layers with dive 0.12.0 #510

Open
Maddog2050 opened this issue Feb 23, 2024 · 2 comments · May be fixed by #511
Open

Docker containerd format fails to parse layers with dive 0.12.0 #510

Maddog2050 opened this issue Feb 23, 2024 · 2 comments · May be fixed by #511
Labels
bug Something isn't working

Comments

@Maddog2050
Copy link

What happened:
When using the option "Use containerd for pulling and storing images" dive fails to parse the layers

$ dive python:3.10-slim-bookworm
Image Source: docker://python:3.10-slim-bookworm
Fetching image... (this can take a while for large images)
cannot fetch image
could not find 'blobs/sha256/93fc0ed6cd0f751d87163f074fea0524d6706bfc30f3be445cdbcaa9d6f187b2' in parsed layers

What you expected to happen:

dive should be able to parse this format

How to reproduce it (as minimally and precisely as possible):

Tick the option "Use containerd for pulling and storing images" in the docker desktop settings, apply the change which should reload docker desktop. Then run dive python:3.10-slim-bookworm

Environment:

  • Dive version: 0.12.0
  • OS version: Mac OS Sonoma 14.3.1 (Arm64)
  • Docker version (if applicable): v4.27.2
@Maddog2050 Maddog2050 added the bug Something isn't working label Feb 23, 2024
@Maddog2050 Maddog2050 linked a pull request Feb 23, 2024 that will close this issue
Open
@zhengcan
Copy link

zhengcan commented May 9, 2024

any progress here?

@cayla cayla mentioned this issue May 15, 2024
Open
@mjpieters mjpieters mentioned this issue Sep 14, 2024
Open
@voltagex
Copy link

Thanks for this @Maddog2050, but it might need another try

PS C:\git\dive> dive mcr.microsoft.com/devcontainers/python:3.11
Image Source: docker://mcr.microsoft.com/devcontainers/python:3.11
Fetching image... (this can take a while for large images)
cannot fetch image
could not find 'blobs/sha256/22cc13c843ff9bae94e16f16ae20d988db591f4da2adde65ff7f7af9c9b116a0' in parsed layers
PS C:\git\dive> curl.exe -LO https://github.com/wagoodman/dive/pull/511.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100  2168    0  2168    0     0   1447      0 --:--:--  0:00:01 --:--:--  1447
PS C:\git\dive> git am .\511.patch
Applying: Fix OCI format, GZIP file can be smaller than 1024 bytes
PS C:\git\dive> go build
PS C:\git\dive> dive mcr.microsoft.com/devcontainers/python:3.11
Image Source: docker://mcr.microsoft.com/devcontainers/python:3.11
Fetching image... (this can take a while for large images)
cannot fetch image
could not find 'blobs/sha256/22cc13c843ff9bae94e16f16ae20d988db591f4da2adde65ff7f7af9c9b116a0' in parsed layers

joschi added a commit to joschi/dive that referenced this issue Nov 6, 2024
@joschi @Maddog2050
fix: fix OCI format, GZIP file can be <1024 bytes (wagoodman#511)
5bfd011 
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <[email protected]>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
@joschi @Maddog2050
fix: fix OCI format, GZIP file can be <1024 bytes (wagoodman#511)
c20ee8a 
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <[email protected]>
joschi added a commit to joschi/dive that referenced this issue Nov 7, 2024
@joschi @Maddog2050
fix: fix OCI format, GZIP file can be <1024 bytes (wagoodman#511)
7bc781d 
Fixes wagoodman#507
Fixes wagoodman#510
Fixes wagoodman#526
Fixes wagoodman#534

Co-authored-by: Maddog2050 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OCI format, GZIP files can be smaller than 1024 bytes Maddog2050/dive
3 participants
@zhengcan @Maddog2050 @voltagex