Fix table of contents sidebar overlapping with EthicalAds placement #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293.
Demo
Before
Screen.Recording.2024-10-29.at.10.22.17.mov
After
Screen.Recording.2024-10-29.at.10.20.50.mov
Issue recap
EthicalAds placement is done with the following CSS:
Meanwhile, our sidebars use Bootstrap's
sticky-top
class that applies the following:There are a few ways we could go about this.
sticky-top
class from Bootstrap, that we use for both sidebars.[data-ea-style=stickybox].loaded
. This seems brittle.sphinx-wagtail-theme/sphinx_wagtail_theme/layout.html
Line 114 in 25ccf64
sphinx-wagtail-theme/sphinx_wagtail_theme/layout.html
Line 156 in 25ccf64
This PR uses approach 1. I changed all of the z-index values and not just the sticky one, because Bootstrap's docs says the following:
I'm not sure of the implications this may have though, but from what I can tell our theme doesn't use dropdowns,
fixed
, modals, popovers, or tooltips.