Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow query messages based on message hash from waku store #1010

Closed
kaichaosun opened this issue Jan 24, 2024 · 2 comments · Fixed by #1028
Closed

feat: allow query messages based on message hash from waku store #1010

kaichaosun opened this issue Jan 24, 2024 · 2 comments · Fixed by #1028
Labels
status-waku-integ All issues relating to the Status Waku integration.

Comments

@kaichaosun
Copy link
Contributor

Problem

The message reliability is a big milestone we are trying to achieve, a few options are discussed at here and here.

To ensure a message is stored by a store service node, client should be able to query a message based on message hash from store node.

Query messages based on message hash is also required in sync protocol research.

Suggested solution

Add or extend the current time range based message query to allow only query the matched messages based on a list of message hash.

@fryorcraken fryorcraken added this to Waku Jan 24, 2024
@kaichaosun kaichaosun added the status-waku-integ All issues relating to the Status Waku integration. label Jan 24, 2024
@kaichaosun kaichaosun moved this from Todo to In Progress in Status Waku Integration & Chat Reliability Jan 24, 2024
@kaichaosun kaichaosun self-assigned this Jan 24, 2024
@chair28980 chair28980 moved this to In Progress in Waku Feb 6, 2024
@chair28980 chair28980 moved this from In Progress to To Do in Waku Feb 6, 2024
@chair28980 chair28980 moved this from In Progress to Todo in Status Waku Integration & Chat Reliability Feb 6, 2024
@kaichaosun
Copy link
Contributor Author

Waiting for Store spec upgrade complete, vacp2p/rfc#665

@chaitanyaprem chaitanyaprem linked a pull request Feb 16, 2024 that will close this issue
6 tasks
@richard-ramos
Copy link
Member

WIP in this PR: #1028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-waku-integ All issues relating to the Status Waku integration.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants