-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: parameterize handshake patterns #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IX pattern should be defined as follows: [
new MessagePattern(MessageDirection.r, [NoiseTokens.e, NoiseTokens.s]),
new MessagePattern(MessageDirection.l, [
NoiseTokens.e,
NoiseTokens.s,
NoiseTokens.es,
NoiseTokens.se,
NoiseTokens.ee,
]),
] |
…ecryption, as it is only used for tests, and not during normal usage
The following tasks will be done in a separate PR:
|
richard-ramos
changed the title
refactor: parameterize handshake patterns and introduce new handshake pattern
refactor: parameterize handshake patterns
Nov 22, 2023
weboko
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took longer to digest, good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://rfc.vac.dev/spec/70/ a new pattern is defined that uses a different DH, Cipher and Hash function.
js-noise currently only accepts 25519, ChaChaPoly and Sha256. With this PR it should be possible to use also other types as long as they follow stablelib
Hash
interface,DHKey
andCipher
interface- Allow AES256GCM Cipher- Allow x448 key?- DefineNoise_IX_448_AES256GCM_SHA256
patternFixes #48