feat!: determine pubsubTopic based on contentTopic #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adklempner what do you think about this approach? |
Comment on lines
-80
to
+81
| return ( | ||
| "/" + qr.applicationName + "/" + qr.applicationVersion + "/wakunoise/1/sessions_shard-" + qr.shardId + "/proto" | ||
| ); | ||
| return "/" + qr.applicationName + "/" + qr.applicationVersion + "/" + qr.shardId + "/proto"; |
There was a problem hiding this comment.
What is the reason behind this change?
There was a problem hiding this comment.
This change is to align with convention towards contentTopic as stated in here https://github.com/vacp2p/rfc-index/blob/main/waku/informational/23/topics.md
There was a problem hiding this comment.
if it is not followed - then we won't be able to map it to shards when autosharding is default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In latest fleet deploy there is no support of default pubsubtopic
Which means now it should be determined based on contentTopic