Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unresolved trailing commas #1483

Closed
danisharora099 opened this issue Aug 16, 2023 · 1 comment
Closed

bug: unresolved trailing commas #1483

danisharora099 opened this issue Aug 16, 2023 · 1 comment

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Aug 16, 2023

This is a bug report/feature or change request/support request

Problem

the js-waku codebase currently has unresolved random trailing commas that originate from a conflict between default prettier config (yes trailing commas) and our eslint config (no trailing commas)

example: https://github.com/waku-org/js-waku/actions/runs/5880486318/job/15946890831?pr=1466

another example: https://github.com/waku-org/js-waku/actions/runs/5890355093/job/15975276872?pr=1469

ref: #1475

Proposed Solutions

probably needs to be resolved by eslint --write

@fryorcraken fryorcraken added this to Waku Aug 16, 2023
@weboko weboko moved this to In Progress in Waku Aug 31, 2023
@danisharora099 danisharora099 moved this from In Progress to Code Review / QA in Waku Sep 1, 2023
@danisharora099 danisharora099 moved this from Code Review / QA to Done in Waku Sep 5, 2023
@danisharora099
Copy link
Collaborator Author

done with #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant