Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peer discovery with dynamic shards as dimension #1504

Closed
chair28980 opened this issue Aug 24, 2023 · 4 comments
Closed

feat: Peer discovery with dynamic shards as dimension #1504

chair28980 opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@chair28980
Copy link
Contributor

Tracks work necessary to ensure that nodes can filter discovered peers according to the shards the node is currently subscribed to and for the node to update its own discoverable ENR every time its subscription set changes.

Priority: Critical for launch.

@fryorcraken fryorcraken added this to Waku Aug 24, 2023
@chair28980 chair28980 changed the title feat: feat: Peer discovery with dynamic shards as dimension Aug 24, 2023
@chair28980
Copy link
Contributor Author

waku-org/research#3

@danisharora099 @weboko

Per the research issue, can y'all verify if this is required for JSWaku and assign ownership as necessary. Thank you!

@danisharora099 danisharora099 moved this to Triage in Waku Sep 7, 2023
@fryorcraken fryorcraken added E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details and removed E:2023-1mil-users labels Sep 8, 2023
@weboko
Copy link
Collaborator

weboko commented Sep 21, 2023

Keeping unassigned for now as it is not clear if it belongs to auto/static sharding or should be done separately.

@fryorcraken
Copy link
Collaborator

For static sharding, we can assume that the shards do not change mid execution. so this issue would not be needed to deliver it.

@weboko weboko moved this from Triage to To Do in Waku Oct 31, 2023
@chair28980 chair28980 moved this from To Do to Icebox in Waku Jan 3, 2024
@danisharora099 danisharora099 moved this from Icebox to Triage in Waku Jan 3, 2024
@danisharora099 danisharora099 moved this from Triage to Code Review / QA in Waku Jan 17, 2024
@danisharora099
Copy link
Collaborator

The latter does not apply to js-waku as it does not change the ENR, as js-waku nodes don't participate in discv5.

The former will be resolved with #1756

@chair28980 chair28980 moved this from Code Review / QA to Done in Waku Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Archived in project
Development

No branches or pull requests

4 participants