Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Waku Network cluster id as default for autosharding #1776

Closed
adklempner opened this issue Jan 9, 2024 · 1 comment · Fixed by #1780
Closed

use Waku Network cluster id as default for autosharding #1776

adklempner opened this issue Jan 9, 2024 · 1 comment · Fixed by #1780
Assignees
Labels
enhancement New feature or request

Comments

@adklempner
Copy link
Member

This is a feature or change request

Problem

To setup a node for autosharding, a user needs to explicitly specify both content topics and a cluster id to determine the pubsub topics. According to the RFC, the Waku Network always uses a cluster id of 1.

Proposed Solutions

Modify any functions that accept sharding parameters to accept a list of content topics without a cluster id, in which case the default cluster id should be set.

Notes

@fryorcraken fryorcraken added this to Waku Jan 9, 2024
@adklempner adklempner moved this to In Progress in Waku Jan 10, 2024
@adklempner adklempner self-assigned this Jan 10, 2024
@adklempner adklempner moved this from In Progress to Code Review / QA in Waku Jan 24, 2024
@chair28980 chair28980 added the enhancement New feature or request label Jan 24, 2024
@chair28980
Copy link
Contributor

Internal dogfooding issue: #1812

@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants