Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: nwaku nodes started on The Waku Network requires a RPC endpoint #1914

Closed
danisharora099 opened this issue Mar 13, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working test Issue related to the test suite with no expected consequence to production code

Comments

@danisharora099
Copy link
Collaborator

Problem

Within our tests suite, we have tests that also attempt connection with nodes started on cluster ID = 1 and after the v0.26.0 update, it expects a RPC endpoint passed along to fetch contract re data.

Proposed Solutions

  • Use a public RPC endpoint that we can also push to GH without any security concerns
  • Use environment variables for the RPC endpoint
@fryorcraken fryorcraken added this to Waku Mar 13, 2024
@rymnc
Copy link

rymnc commented Mar 13, 2024

something that is tangentially related to this issue, please ensure that the rln_tree is persisted across runs so the nwaku nodes finish sync and startup quicker

@chair28980 chair28980 moved this to Triage in Waku Mar 13, 2024
@chair28980 chair28980 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 13, 2024
@danisharora099
Copy link
Collaborator Author

something that is tangentially related to this issue, please ensure that the rln_tree is persisted across runs so the nwaku nodes finish sync and startup quicker

Good point!

@weboko weboko moved this from Triage to Priority in Waku Apr 24, 2024
@weboko
Copy link
Collaborator

weboko commented Apr 24, 2024

Moving to Priority as we need to address it sooner than later.
For now tests are using different cluster IDs to avoid nwaku nodes from failing to run.

@weboko weboko added the test Issue related to the test suite with no expected consequence to production code label Apr 25, 2024
@weboko weboko changed the title nwaku nodes started on The Waku Network requires a RPC endpoint test: nwaku nodes started on The Waku Network requires a RPC endpoint Apr 25, 2024
@adklempner adklempner self-assigned this May 2, 2024
@adklempner adklempner moved this from Priority to In Progress in Waku May 2, 2024
@weboko
Copy link
Collaborator

weboko commented May 9, 2024

@fbarbu15 can you, please, give your input on this issue?

In particular, if we foresee many tests in future to use this?

@fbarbu15
Copy link
Collaborator

On the interop testing side we use cluster id 1 only to test RLN. So the testing around this cluster is contained. Tests on this cluster id are also more complex and slower (node can take more than 1 minute to fully start) because of RLN so it's another reason to avoid it.
So I think it will be the same case for js-waku tests

@weboko
Copy link
Collaborator

weboko commented May 14, 2024

Summarizing - we foresee such tests in js-waku in future but not now.
@adklempner merged the PR and the job is now skipped in CI.

Once it is needed I think QA team will re-enable this step and will update with needed changes.

Closing as complete.

@weboko weboko closed this as completed May 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issue related to the test suite with no expected consequence to production code
Projects
Status: Done
Development

No branches or pull requests

6 participants