Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cannot use multiaddr with 127.0.0.1 to dial #1974

Open
weboko opened this issue Apr 24, 2024 · 0 comments
Open

bug: cannot use multiaddr with 127.0.0.1 to dial #1974

weboko opened this issue Apr 24, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@weboko
Copy link
Collaborator

weboko commented Apr 24, 2024

This is a bug report/feature request/support request/change request

Problem

If /dns4/127.0.0.1/tcp/8000/ws/p2p/16Uiu2HAkxcq84cB1gD1MH5XDQNm1vakvUzwoEhmLFtywF7YF3Hvm is used to dial - then error is thrown from websocket transport here

Works just fine if ``/dns4/localhost/tcp/8000/ws/p2p/16Uiu2HAkxcq84cB1gD1MH5XDQNm1vakvUzwoEhmLFtywF7YF3Hvm` is used.

Proposed Solutions

Since nwaku generates multiaddr with IP in it - we should be able to dial it without error.
Most straightforward solution can be to check for 127.0.0.1 and replace with localhost.
But we also need to check why this throw actually happens as there might be unintended consequences.

@weboko weboko added bug Something isn't working enhancement New feature or request labels Apr 24, 2024
@weboko weboko added this to Waku Apr 24, 2024
@weboko weboko moved this to Triage in Waku Apr 24, 2024
@weboko weboko moved this from Triage to To Do in Waku Apr 24, 2024
@weboko weboko added the good first issue Good for newcomers label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
Status: To Do
Development

No branches or pull requests

1 participant