Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move Peer to PeerId #2246

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: move Peer to PeerId #2246

wants to merge 1 commit into from
+118 −125

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jan 31, 2025 •
edited
Loading

Problem / Description

During core protocol operations we often await peerStore to get us Peer based on PeerId.
Upon looking into the code, it appears as unnecessary step.

Solution

Replace that usage.

Notes

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 84.59 KB (-0.18% 🔽) 1.7 s (-0.18% 🔽) 2.7 s (-24.56% 🔽) 4.4 s
Waku Simple Light Node 135.67 KB (-0.05% 🔽) 2.8 s (-0.05% 🔽) 3 s (-21.67% 🔽) 5.7 s
ECIES encryption 22.73 KB (0%) 455 ms (0%) 1.4 s (+26.93% 🔺) 1.9 s
Symmetric encryption 22.23 KB (0%) 445 ms (0%) 948 ms (+5.21% 🔺) 1.4 s
DNS discovery 70.8 KB (0%) 1.5 s (0%) 2 s (+8.62% 🔺) 3.4 s
Peer Exchange discovery 71.79 KB (-0.01% 🔽) 1.5 s (-0.01% 🔽) 2.1 s (-10.47% 🔽) 3.6 s
Local Peer Cache Discovery 65.39 KB (0%) 1.4 s (0%) 1.9 s (-36.57% 🔽) 3.2 s
Privacy preserving protocols 76.52 KB (0%) 1.6 s (0%) 2.2 s (-23.57% 🔽) 3.7 s
Waku Filter 78.11 KB (+0.01% 🔺) 1.6 s (+0.01% 🔺) 2.5 s (-12.32% 🔽) 4.1 s
Waku LightPush 75.68 KB (+0.12% 🔺) 1.6 s (+0.12% 🔺) 2 s (-44.59% 🔽) 3.5 s
History retrieval protocols 75.77 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 1.6 s (-37.41% 🔽) 3.1 s
Deterministic Message Hashing 7.32 KB (0%) 147 ms (0%) 321 ms (-69.36% 🔽) 467 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: make core protocols use PeerId only
1 participant
@weboko