Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add retry to test steps of ci #1517

Merged
merged 9 commits into from
Aug 31, 2023
Merged

chore: add retry to test steps of ci #1517

merged 9 commits into from
Aug 31, 2023

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Aug 30, 2023

Problem

It happens that our CI fails due to timeouts.

Solution

Add some amount of additional retry attempts, 3 for now.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 28.67 KB (0%) 574 ms (0%) 1.9 s (-9.79% 🔽) 2.5 s
Waku Simple Light Node 298.45 KB (0%) 6 s (0%) 4.8 s (+22.8% 🔺) 10.8 s
ECIES encryption 28.68 KB (0%) 574 ms (0%) 1.4 s (+1.08% 🔺) 2 s
Symmetric encryption 28.69 KB (0%) 574 ms (0%) 1.6 s (-11.83% 🔽) 2.2 s
DNS discovery 118.6 KB (0%) 2.4 s (0%) 3.1 s (+6.18% 🔺) 5.5 s
Privacy preserving protocols 122.62 KB (0%) 2.5 s (0%) 3.9 s (+47.5% 🔺) 6.3 s
Light protocols 28.4 KB (0%) 568 ms (0%) 1.7 s (-20.78% 🔽) 2.3 s
History retrieval protocols 27.64 KB (0%) 553 ms (0%) 1.4 s (-30.74% 🔽) 1.9 s
Deterministic Message Hashing 5.64 KB (0%) 113 ms (0%) 611 ms (+50.45% 🔺) 724 ms

@weboko weboko marked this pull request as ready for review August 30, 2023 22:23
@weboko weboko requested a review from a team as a code owner August 30, 2023 22:23
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@weboko weboko merged commit 73dd948 into master Aug 31, 2023
10 checks passed
@weboko weboko deleted the weboko/retry-ci branch August 31, 2023 10:27
@weboko weboko mentioned this pull request Aug 31, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants