feat: add rpc url to nwaku, persist rln tree in docker and ci #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/docker-sepolia-rpc
branch
from
f207d99 to
72e5a71
Compare
size-limit report 📦
|
adklempner
force-pushed
the
feat/docker-sepolia-rpc
branch
6 times, most recently
from
56358a9 to
832e7cc
Compare
adklempner
force-pushed
the
feat/docker-sepolia-rpc
branch
2 times, most recently
from
e7bef35 to
6f847ea
Compare
adklempner
force-pushed
the
feat/docker-sepolia-rpc
branch
from
6f847ea to
9ce3e6b
Compare
fbarbu15
approved these changes
May 13, 2024
.github/workflows/ci.yml
Outdated
| npm run sync-rln-tree | ||
| tar -czf rln_tree.tar.gz -C /tmp/rln_tree.db . | ||
| - name: Upload artifact | ||
| uses: actions/upload-artifact@v2 |
There was a problem hiding this comment.
There's a newer version of this action: actions/upload-artifact@v4
.github/workflows/ci.yml
Outdated
| } | ||
| - name: Download RLN tree artifact | ||
| if: steps.check-artifact.outputs.artifact_found == 'true' | ||
| uses: actions/download-artifact@v3 |
There was a problem hiding this comment.
There's a newer version of this action: actions/download-artifact@v4
adklempner
force-pushed
the
feat/docker-sepolia-rpc
branch
from
9ce3e6b to
aad819b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tests that run against cluster id 1 (The Waku Network) require running an nwaku node with a sepolia RPC url.
When adding this parameter, the nwaku node will not be "ready" (
/healthreturns status 200) until the RLN tree is synced. If starting from scratch, this process takes a long time (up to 5 minutes, and will only take longer as more blocks are mined on Sepolia).Solution
Add a step to the CI that:
rln_tree.dbis stored as an artifact. If so, pull it.rln_tree.dbuntil the/healthendpoint returns 200 (basically syncs the rln_tree to latest block on sepolia)rln_tree.dbas an artifactFor now, the step is disabled. When we have tests that run against TWN, we will enable this job and have it be a prereq for running those tests.
Notes
Contribution checklist:
!in title if breaks public API;