Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seemingly arbitrary leniency towards commas #49

Open
Ictoan42 opened this issue May 9, 2024 · 0 comments
Open

Seemingly arbitrary leniency towards commas #49

Ictoan42 opened this issue May 9, 2024 · 0 comments

Comments

@Ictoan42
Copy link
Contributor

Ictoan42 commented May 9, 2024

Currently some formats allow unnecessary commas others enforce commas in specific places, and others disallow commas entirely. A few examples:

  • 12 September 2013 parses correctly
  • 12 September, 2013 does not parse
  • September 12, 2013 parses correctly
  • September 12 2013 does not parse
  • September 12 2013 08:00 UTC parses correctly
  • September 12 2013 08:00 does not parse
  • September 12, 2013 08:00 parses correctly

I'm looking to put together a PR about this (I've already done some brief tests, looking to make it lenient in every case i could think of) but I just wanted to check if this is something you'd be interested in, and check that there aren't any massive pitfalls that I haven't noticed yet that are enforcing the current behaviour

@Ictoan42 Ictoan42 changed the title Arbitrary leniency towards commas Seemingly arbitrary leniency towards commas May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant