Revert "Guard diag in avifDiagnosticsClearError()"

This reverts commit 173961d in the 1.0.0 release, to give us more time to re-evaluate AOMediaCodec#1496.
wantehchang · Aug 25, 2023 · bd6bc1d · bd6bc1d
1 parent a78b867
commit bd6bc1d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/diag.c b/src/diag.c
@@ -9,9 +9,7 @@
 
 void avifDiagnosticsClearError(avifDiagnostics * diag)
 {
-    if (diag) {
-        *diag->error = '\0';
-    }
+    *diag->error = '\0';
 }
 
 #ifdef __clang__
@@ -20,6 +18,7 @@ __attribute__((__format__(__printf__, 2, 3)))
 void avifDiagnosticsPrintf(avifDiagnostics * diag, const char * format, ...)
 {
     if (!diag) {
+        // It is possible this is NULL (e.g. calls to avifPeekCompatibleFileType())
         return;
     }
     if (*diag->error) {