Answer with a 400 if the macaroon is malformed instead of a 500

[urcadox]

The macaroons lib throws an exception if the macaroon is malformed which is not caught.

[FlorentinDUBOIS]

May be it will be better to answer with a 401 HTTP Code ?

[urcadox]

That's debatable I guess. What I usually do for an endpoint which needs the user to be authenticated is this: - No authentication provided: 401 - Authentication provided but the user is not authorized to do this: 403 - Authentication provided but it was malformed, broken or otherwise incorrect: 400 Le mar. 20 mars 2018 à 18:34, Florentin DUBOIS <[email protected]> a écrit :

…

May be it will be better to answer with a 401 HTTP Code ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2a3CkBUCIRSYCQe5kyv7VupmDVAClaks5tgT2IgaJpZM4SyPX8> .

[FlorentinDUBOIS]

It works to me. This way to answer the client is quite relevant.